keep current#880
Merged
Merged
Conversation
Adds Sphinx doctest Examples sections to DevelopmentCorrelation and ValuationCorrelation. Each example opens with the Mack chain-ladder assumption being tested, prints the full decision signal (statistic, confidence band, and boolean) rather than a single boolean, and ties the result back to the chain-ladder workflow. Refs #704
Adds Sphinx doctest Examples section to the BootstrapODPSample class showing basic fit (resampled_triangles_.shape and scale_), downstream stochastic IBNR via Chainladder, and the effect of drop_high on scale_. Uses random_state=42 and n_sims=100 for deterministic, fast output. Refs #704
Rewords the paragraph introducing the drop_high=True example to describe it as a leave-one-out sensitivity check on the column maxima rather than outlier removal, since drop_high mechanically removes the column max without any outlier test. Addresses review feedback on #836.
Per @henrydingliu review on #844: opening paragraph now scoped to the calendar-effect concept; the per-diagonal vs whole-triangle distinction is introduced as a transition between the two testcode blocks. Refs #704
- Drop the jb build internals + duplicate warnings note (kennethshsu) - Rename 'tutorial notebooks' to 'onboarding and Quickstart notebooks' (kennethshsu) - Drop the 'What to edit for which part of the site' table and 'Known issues' section as redundant with the Source files table and #841 (kennethshsu)
…missing unit tests.
…stic values for changed options.
docs: add README documenting docs build sources and outputs
Improved docstring and added examples for Development class
[REFACTOR]: Remove repetitive code. Remove dead Python 3.8 code. Add …
…option getters and setters. Deprecate cl.array_backend() and cl.auto_sparse()
first batch of deliverables for friedland reconstruction
[REFACTOR]: Continue work on cl.__init__.py refactor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental #880 +/- ##
================================================
+ Coverage 86.94% 87.04% +0.09%
================================================
Files 86 86
Lines 4994 4986 -8
Branches 644 646 +2
================================================
- Hits 4342 4340 -2
+ Misses 462 456 -6
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Datetime handling and options API changes affect core triangle valuation paths across the package; removing deprecated helpers is a breaking change for callers still using them.
Overview
Refactors package configuration so datetime precision follows Pandas via module-level
__dt64_dtype__/__dt64_unit__instead of configurableoptions.DT64_*, and reworksOptionsas an instance with validatedget/set/reset(including per-option reset). Removes the deprecated top-levelarray_backend()andauto_sparse()helpers in favor ofchainladder.options.Documentation and tests expand substantially: doctest Examples on
Development,BootstrapODPSample, and Mack correlation classes; a newdocs/README.mdcontributor guide; Friedland chapters 6–7 (RST) plus chapter 8 notebook wired into_toc.yml; and richer options unit tests plus a shared_sample_fixtureinconftest.py.Minor housekeeping: trailing newline on CODEOWNERS,
pyproject.tomldocs deps formatting, andlibrary/apiautosummary stub fix forDevelopment.Reviewed by Cursor Bugbot for commit 449b5c1. Bugbot is set up for automated code reviews on this repo. Configure here.